Contributor Question: How Best to Create Pull Request Using a git-svn Clone?

[Eliot Kimber]

I've done my work in a git-svn clone of the project, but reviewing the contributor guidance it's not clear to me how best to create a pull request or patch submission in this case.

Maybe I should have used the read-only git repo on GitHub?

Thanks,

E.
--
Eliot Kimber
http://contrext.com




---------------------------------------------------------------------
To unsubscribe, e-mail: user-***@poi.apache.org
For additional commands, e-mail: user-***@poi.apache.org

[Murphy, Mark]

It depends on who goes about reviewing your changes. Most don't care, PJ prefers a git pull request. I generally do my real work in svn, and test stuff in a git clone.

-----Original Message-----
From: Eliot Kimber [mailto:***@contrext.com]
Sent: Friday, July 20, 2018 12:00 PM
To: POI Users List <***@poi.apache.org>
Subject: Contributor Question: How Best to Create Pull Request Using a git-svn Clone?

I've done my work in a git-svn clone of the project, but reviewing the contributor guidance it's not clear to me how best to create a pull request or patch submission in this case.

Maybe I should have used the read-only git repo on GitHub?

Thanks,

E.
--
Eliot Kimber
http://contrext.com




---------------------------------------------------------------------
To unsubscribe, e-mail: user-***@poi.apache.org For additional commands, e-mail: user-***@poi.apache.org

Т���������������������������������������������������������������������ХF�V�7V'67&�&R�R���âW6W"�V�7V'67&�&T���6�R��&pФf�"FF�F����6����G2�R����

[Dominik Stadler]

Hi,

Unfortunately git-svn repositories are not compatible with the github
version due to different meta-data in the commits, so you cannot easily
connect both. With git-svn you need to create patches and ideally upload
them to an issue in the bugzilla issue tracker, see
https://poi.apache.org/devel/guidelines.html#SubmittingPatches for
descriptions of the different ways.

Dominik.

Post by Murphy, Mark
It depends on who goes about reviewing your changes. Most don't care, PJ
prefers a git pull request. I generally do my real work in svn, and test
stuff in a git clone.
-----Original Message-----
Sent: Friday, July 20, 2018 12:00 PM
Subject: Contributor Question: How Best to Create Pull Request Using a git-svn Clone?
I've done my work in a git-svn clone of the project, but reviewing the
contributor guidance it's not clear to me how best to create a pull request
or patch submission in this case.
Maybe I should have used the read-only git repo on GitHub?
Thanks,
E.
--
Eliot Kimber
http://contrext.com
---------------------------------------------------------------------